leventov commented on a change in pull request #6349: maintenance mode for
Historical
URL: https://github.com/apache/incubator-druid/pull/6349#discussion_r223038025
##########
File path:
server/src/main/java/org/apache/druid/server/coordinator/CoordinatorDynamicConfig.java
##########
@@ -100,8 +101,12 @@ public CoordinatorDynamicConfig(
this.killDataSourceWhitelist =
parseJsonStringOrArray(killDataSourceWhitelist);
Review comment:
Source code should be understandable and self-contained on it's own. For
somebody to understand it now, it's required to find this doc and then find how
the mentioned property is mapped backed to some source code concepts, that's
very difficult and time-consuming when somebody just wants to read and
understand code.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org
For additional commands, e-mail: commits-h...@druid.apache.org
