leventov commented on a change in pull request #6349: maintenance mode for Historical URL: https://github.com/apache/incubator-druid/pull/6349#discussion_r224180357
########## File path: server/src/main/java/org/apache/druid/server/coordinator/CoordinatorDynamicConfig.java ########## @@ -92,11 +98,17 @@ public CoordinatorDynamicConfig( this.balancerComputeThreads = Math.max(balancerComputeThreads, 1); this.emitBalancingStats = emitBalancingStats; this.killAllDataSources = killAllDataSources; - this.killDataSourceWhitelist = parseJsonStringOrArray(killDataSourceWhitelist); - this.killPendingSegmentsSkipList = parseJsonStringOrArray(killPendingSegmentsSkipList); + this.killableDatasources = parseJsonStringOrArray(killableDatasources); + this.protectedPendingSegmentDatasources = parseJsonStringOrArray(protectedPendingSegmentDatasources); this.maxSegmentsInNodeLoadingQueue = maxSegmentsInNodeLoadingQueue; + this.historicalNodesInMaintenance = parseJsonStringOrArray(historicalNodesInMaintenance); + Preconditions.checkArgument( + nodesInMaintenancePriority >= 0 && nodesInMaintenancePriority <= 10, + "nodesInMaintenancePriority should be in range [0, 10]" + ); + this.nodesInMaintenancePriority = nodesInMaintenancePriority; - if (this.killAllDataSources && !this.killDataSourceWhitelist.isEmpty()) { + if (this.killAllDataSources && !this.killableDatasources.isEmpty()) { Review comment: @egor-ryashin could you please rename to killableData**S**ources that is more conventional spelling ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org For additional commands, e-mail: commits-h...@druid.apache.org