himanshug commented on a change in pull request #6419: Add ability to specify
dbcp properties file
URL: https://github.com/apache/incubator-druid/pull/6419#discussion_r224575966
##########
File path:
common/src/main/java/org/apache/druid/metadata/MetadataStorageConnectorConfig.java
##########
@@ -44,6 +53,9 @@
@JsonProperty("password")
private PasswordProvider passwordProvider;
+ @JsonProperty("dbcpPropertiesFile")
+ private String dbcpPropertiesFile;
Review comment:
this requires users to deploy a new configuration file... how about changing
above to something like...
```
@JsonProperty("dbcp")
private Properties dbcpProperties;
public Properties getDbcpProperties()
{
return dbcpProperties == null ? new Properties() : dbcpProperties;
}
```
then user can just put following kind of things in druid runtime.properties
file...
```
druid.metadata.storage.connector.dbcp.maxConnLifetimeMillis=1200000
druid.metadata.storage.connector.dbcp.defaultQueryTimeout=30000
....
```
I think that should work..
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
