himanshug commented on a change in pull request #6419: Add ability to specify
dbcp properties file
URL: https://github.com/apache/incubator-druid/pull/6419#discussion_r224925052
##########
File path:
common/src/main/java/org/apache/druid/metadata/MetadataStorageConnectorConfig.java
##########
@@ -78,6 +82,11 @@ public String getPassword()
return passwordProvider == null ? null : passwordProvider.getPassword();
}
+ public Properties getDbcpProperties()
+ {
+ return dbcpProperties;
Review comment:
I see your point ... I thought it would be cleaner to not return null. but
it is one of those "preference" things so I will leave it up to you... feel
free to skip this comment.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
