leventov commented on a change in pull request #5028: Add result level caching
to Brokers
URL: https://github.com/apache/incubator-druid/pull/5028#discussion_r228702103
##########
File path:
processing/src/main/java/io/druid/query/groupby/GroupByQueryQueryToolChest.java
##########
@@ -426,6 +427,11 @@ public Object apply(Row input)
for (AggregatorFactory agg : aggs) {
Review comment:
@a2l007
```
final List<Object> retVal = Lists.newArrayListWithCapacity(1 + dims.size() +
aggs.size());
```
a few lines above is not updated wrt getPostAggregatorSpecs. Similar
problems in other classes, updated in this PR. Also I noticed that somewhere
this sizing was buggy before this PR already.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
