leventov opened a new issue #6536: SearchThresholdAdjustingQueryRunner and TopNQueryQueryToolChest.ThresholdAdjustingQueryRunner sanity URL: https://github.com/apache/incubator-druid/issues/6536 Those classes don't make sense to me. E. g. with TopN, whether the query threshold is 3 or 300 or 3000, it always could make sense to have per-historical / per-segment threshold (is this what is meant by "minTopNThreshold", right?) of 1000. They are independent. Also it's really hard to understand how the manipulation happens across broker/historical boundary, because within a Historical it's a wastful no-op (extend the threshold and then trim the results again). For `SearchThresholdAdjustingQueryRunner`, `Iterables.limit()` modification is a no-op (because `query.getLimit()` is bigger than `config.getMaxSearchLimit()`). @gianm @drcrallen
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
