vtlim commented on code in PR #17740:
URL: https://github.com/apache/druid/pull/17740#discussion_r1965976300
##########
docs/development/extensions-core/catalog.md:
##########
@@ -68,7 +68,7 @@ A tableSpec defines a table
|--------------|---------------------|------------------------------------------------------------------------------------------------------------------------|----------|---------|
| `name` | String | The name of the column
| yes | null |
| `dataType` | String | The type of the column. Can be any
column data type that is available to Druid. Depends on what extensions are
loaded. | no | null |
-| `properties` | Map<String, Object> | the column's defined properties. Non
properties defined at this time.
| no | null |
+| `properties` | Map<String, Object\> | the column's defined properties.
Non properties defined at this time.
| no | null |
Review Comment:
If the `>` needs a backslash, do you also need to for lines 55-56?
##########
docs/configuration/extensions.md:
##########
@@ -101,7 +101,7 @@ All of these community extensions can be downloaded using
[pull-deps](../operati
|druid-momentsketch|Support for approximate quantile queries using the
[momentsketch](https://github.com/stanford-futuredata/momentsketch)
library|[link](../development/extensions-contrib/momentsketch-quantiles.md)|
|druid-tdigestsketch|Support for approximate sketch aggregators based on
[T-Digest](https://github.com/tdunning/t-digest)|[link](../development/extensions-contrib/tdigestsketch-quantiles.md)|
|gce-extensions|GCE
Extensions|[link](../development/extensions-contrib/gce-extensions.md)|
-|prometheus-emitter|Exposes [Druid metrics](../operations/metrics.md) for
Prometheus server collection
(<https://prometheus.io/>)|[link](../development/extensions-contrib/prometheus.md)|
+|prometheus-emitter|Exposes [Druid metrics](../operations/metrics.md) for
Prometheus server collection
(https://prometheus.io/)|[link](../development/extensions-contrib/prometheus.md)|
Review Comment:
```suggestion
|prometheus-emitter|Exposes [Druid metrics](../operations/metrics.md) for
[Prometheus](https://prometheus.io/) server collection
|[link](../development/extensions-contrib/prometheus.md)|
```
##########
docs/querying/math-expr.md:
##########
@@ -43,7 +43,7 @@ This expression language supports the following operators
(listed in decreasing
|^|Binary power op|
|*, /, %|Binary multiplicative|
|+, -|Binary additive|
-|<, <=, >, >=, ==, !=|Binary Comparison|
+|<, ≤, >, ≥, ==, ≠|Binary Comparison|
Review Comment:
The `!=` shows up as `≠`, not sure if that's intentional
##########
docs/ingestion/data-formats.md:
##########
@@ -399,7 +399,7 @@ For details, see the Schema Registry
[documentation](http://docs.confluent.io/cu
| type | String | Set value to `schema_registry`. | no |
| url | String | Specifies the URL endpoint of the Schema Registry. | yes |
| capacity | Integer | Specifies the max size of the cache (default =
Integer.MAX_VALUE). | no |
-| urls | Array<String\> | Specifies the URL endpoints of the multiple Schema
Registry instances. | yes (if `url` is not provided) |
+| urls | Array\<String\> | Specifies the URL endpoints of the multiple Schema
Registry instances. | yes (if `url` is not provided) |
Review Comment:
also applies to other instances throughout
##########
docs/querying/nested-columns.md:
##########
@@ -330,7 +330,7 @@ FROM (
PARTITIONED BY ALL
```
-## Ingest a JSON string as COMPLEX<json\>
+## Ingest a JSON string as COMPLEX\<json\>
Review Comment:
also here
##########
docs/ingestion/data-formats.md:
##########
@@ -399,7 +399,7 @@ For details, see the Schema Registry
[documentation](http://docs.confluent.io/cu
| type | String | Set value to `schema_registry`. | no |
| url | String | Specifies the URL endpoint of the Schema Registry. | yes |
| capacity | Integer | Specifies the max size of the cache (default =
Integer.MAX_VALUE). | no |
-| urls | Array<String\> | Specifies the URL endpoints of the multiple Schema
Registry instances. | yes (if `url` is not provided) |
+| urls | Array\<String\> | Specifies the URL endpoints of the multiple Schema
Registry instances. | yes (if `url` is not provided) |
Review Comment:
undo this change? the first `\` shows up
##########
docs/release-info/release-notes.md:
##########
@@ -24,15 +24,15 @@ title: "Release notes"
<!--Replace {{DRUIDVERSION}} with the correct Druid version.-->
-Apache Druid {{DRUIDVERSION}} contains over $NUMBER_FEATURES new features, bug
fixes, performance enhancements, documentation improvements, and additional
test coverage from $NUMBER_OF_CONTRIBUTORS contributors.
+Apache Druid \{\{DRUIDVERSION}} contains over $NUMBER_FEATURES new features,
bug fixes, performance enhancements, documentation improvements, and additional
test coverage from $NUMBER_OF_CONTRIBUTORS contributors.
Review Comment:
This is showing up as `Apache Druid {\32.0.0} contains `
##########
docs/tutorials/tutorial-batch-hadoop.md:
##########
@@ -148,7 +148,7 @@ From the Hadoop container's shell, run the following
command to copy the Hadoop
cp /usr/local/hadoop/etc/hadoop/*.xml /shared/hadoop_xml
```
-From the host machine, run the following, where {PATH_TO_DRUID} is replaced by
the path to the Druid package.
+From the host machine, run the following, where \{PATH_TO_DRUID\} is replaced
by the path to the Druid package.
Review Comment:
Does this get interpreted at build or later? I see
```
From the host machine, run the following, where {PATH_TO_DRUID} is replaced
by the path to the Druid package.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
