317brian commented on code in PR #17740:
URL: https://github.com/apache/druid/pull/17740#discussion_r1990184503
##########
docs/ingestion/ingestion-spec.md:
##########
@@ -243,7 +243,7 @@ Dimension objects can have the following components:
| Field | Description | Default |
|-------|-------------|---------|
-| type | Either `auto`, `string`, `long`, `float`, `double`, or `json`. For
the `auto` type, Druid determines the most appropriate type for the dimension
and assigns one of the following: STRING, ARRAY<STRING\>, LONG, ARRAY<LONG\>,
DOUBLE, ARRAY<DOUBLE\>, or COMPLEX<json\> columns, all sharing a common
'nested' format. When Druid infers the schema with schema auto-discovery, the
type is `auto`. | `string` |
+| type | Either `auto`, `string`, `long`, `float`, `double`, or `json`. For
the `auto` type, Druid determines the most appropriate type for the dimension
and assigns one of the following: STRING, Array\<String\>, LONG, ARRAY\<LONG\>,
DOUBLE, ARRAY\<DOUBLE\>, or COMPLEX\<json\> columns, all sharing a common
'nested' format. When Druid infers the schema with schema auto-discovery, the
type is `auto`. | `string` |
Review Comment:
```suggestion
| type | Either `auto`, `string`, `long`, `float`, `double`, or `json`. For
the `auto` type, Druid determines the most appropriate type for the dimension
and assigns one of the following: STRING, Array<String\>, LONG, ARRAY<LONG\>,
DOUBLE, ARRAY<DOUBLE\>, or COMPLEX<json\> columns, all sharing a common
'nested' format. When Druid infers the schema with schema auto-discovery, the
type is `auto`. | `string` |
```
##########
docs/release-info/upgrade-notes.md:
##########
@@ -173,7 +173,7 @@ Now, excess requests will instead be queued with a timeout
equal to `MIN(Integer
#### Changed how empty or null array columns are stored
-Columns ingested with the auto column indexer that contain only empty or null
arrays are now stored as `ARRAY<LONG\>` instead of `COMPLEX<json\>`.
+Columns ingested with the auto column indexer that contain only empty or null
arrays are now stored as `ARRAY\<LONG\>` instead of `COMPLEX<json\>`.
Review Comment:
```suggestion
Columns ingested with the auto column indexer that contain only empty or
null arrays are now stored as `ARRAY<LONG\>` instead of `COMPLEX<json\>`.
```
##########
docs/tutorials/index.md:
##########
@@ -53,7 +53,7 @@ dedicated user account for running Druid.
## Install Druid
-Download the [{{DRUIDVERSION}} release](https://druid.apache.org/downloads/)
from Apache Druid.
+Download the [\{\{DRUIDVERSION}} release](https://druid.apache.org/downloads/)
from Apache Druid.
Review Comment:
```suggestion
Download the [\{{DRUIDVERSION}}
release](https://druid.apache.org/downloads/) from Apache Druid.
```
##########
docs/querying/math-expr.md:
##########
@@ -65,7 +65,7 @@ The following built-in functions are available.
|name|description|
|----|-----------|
-|cast|cast(expr,LONG or DOUBLE or STRING or ARRAY<LONG\>, or ARRAY<DOUBLE\> or
ARRAY<STRING\>) returns expr with specified type. exception can be thrown.
Scalar types may be cast to array types and will take the form of a single
element list (null will still be null). |
+|cast|cast(expr,LONG or DOUBLE or STRING or ARRAY\<LONG\>, or ARRAY\<DOUBLE\>
or Array\<String\>) returns expr with specified type. exception can be thrown.
Scalar types may be cast to array types and will take the form of a single
element list (null will still be null). |
Review Comment:
```suggestion
|cast|cast(expr,LONG or DOUBLE or STRING or ARRAY<LONG\>, or ARRAY<DOUBLE\>
or Array<String\>) returns expr with specified type. exception can be thrown.
Scalar types may be cast to array types and will take the form of a single
element list (null will still be null). |
```
##########
docs/tutorials/cluster.md:
##########
@@ -150,8 +150,8 @@ First, download and unpack the release archive. It's best
to do this on a single
since you will be editing the configurations and then copying the modified
distribution out to all
of your servers.
-[Download](https://www.apache.org/dyn/closer.cgi?path=/druid/{{DRUIDVERSION}}/apache-druid-{{DRUIDVERSION}}-bin.tar.gz)
-the {{DRUIDVERSION}} release.
+[Download](https://www.apache.org/dyn/closer.cgi?path=/druid/{{DRUIDVERSION}}/apache-druid{DRUIDVERSION}}-bin.tar.gz)
Review Comment:
```suggestion
[Download](https://www.apache.org/dyn/closer.cgi?path=/druid/-{{DRUIDVERSION}}/apache-druid{DRUIDVERSION}}-bin.tar.gz)
```
##########
docs/development/extensions-core/catalog.md:
##########
@@ -68,7 +68,7 @@ A tableSpec defines a table
|--------------|---------------------|------------------------------------------------------------------------------------------------------------------------|----------|---------|
| `name` | String | The name of the column
| yes | null |
| `dataType` | String | The type of the column. Can be any
column data type that is available to Druid. Depends on what extensions are
loaded. | no | null |
-| `properties` | Map<String, Object> | the column's defined properties. Non
properties defined at this time.
| no | null |
+| `properties` | Map<String, Object\> | the column's defined properties.
Non properties defined at this time.
| no | null |
Review Comment:
It needs to either not have both <> or have > escaped
##########
docs/querying/nested-columns.md:
##########
@@ -330,7 +330,7 @@ FROM (
PARTITIONED BY ALL
```
-## Ingest a JSON string as COMPLEX<json\>
+## Ingest a JSON string as COMPLEX\<json\>
Review Comment:
```suggestion
## Ingest a JSON string as COMPLEX<json\>
```
##########
docs/tutorials/cluster.md:
##########
@@ -150,8 +150,8 @@ First, download and unpack the release archive. It's best
to do this on a single
since you will be editing the configurations and then copying the modified
distribution out to all
of your servers.
-[Download](https://www.apache.org/dyn/closer.cgi?path=/druid/{{DRUIDVERSION}}/apache-druid-{{DRUIDVERSION}}-bin.tar.gz)
-the {{DRUIDVERSION}} release.
+[Download](https://www.apache.org/dyn/closer.cgi?path=/druid/{{DRUIDVERSION}}/apache-druid{DRUIDVERSION}}-bin.tar.gz)
+the \{\{DRUIDVERSION}} release.
Review Comment:
```suggestion
the \{{DRUIDVERSION}} release.
```
##########
docs/querying/math-expr.md:
##########
@@ -43,7 +43,7 @@ This expression language supports the following operators
(listed in decreasing
|^|Binary power op|
|*, /, %|Binary multiplicative|
|+, -|Binary additive|
-|<, <=, >, >=, ==, !=|Binary Comparison|
+|<, ≤, >, ≥, ==, ≠|Binary Comparison|
Review Comment:
```suggestion
|<, ≤, >, ≥, ==, !=|Binary Comparison|
```
##########
docs/development/extensions-core/catalog.md:
##########
@@ -68,7 +68,7 @@ A tableSpec defines a table
|--------------|---------------------|------------------------------------------------------------------------------------------------------------------------|----------|---------|
| `name` | String | The name of the column
| yes | null |
| `dataType` | String | The type of the column. Can be any
column data type that is available to Druid. Depends on what extensions are
loaded. | no | null |
-| `properties` | Map<String, Object> | the column's defined properties. Non
properties defined at this time.
| no | null |
+| `properties` | Map<String, Object\> | the column's defined properties.
Non properties defined at this time.
| no | null |
Review Comment:
it doesn't need it:
```suggestion
| `properties` | Map<String, Object> | the column's defined properties.
Non properties defined at this time.
| no | null |
```
##########
docs/ingestion/data-formats.md:
##########
@@ -399,7 +399,7 @@ For details, see the Schema Registry
[documentation](http://docs.confluent.io/cu
| type | String | Set value to `schema_registry`. | no |
| url | String | Specifies the URL endpoint of the Schema Registry. | yes |
| capacity | Integer | Specifies the max size of the cache (default =
Integer.MAX_VALUE). | no |
-| urls | Array<String\> | Specifies the URL endpoints of the multiple Schema
Registry instances. | yes (if `url` is not provided) |
+| urls | Array\<String\> | Specifies the URL endpoints of the multiple Schema
Registry instances. | yes (if `url` is not provided) |
Review Comment:
```suggestion
| urls | Array<String\> | Specifies the URL endpoints of the multiple Schema
Registry instances. | yes (if `url` is not provided) |
```
##########
docs/release-info/release-notes.md:
##########
@@ -24,15 +24,15 @@ title: "Release notes"
<!--Replace {{DRUIDVERSION}} with the correct Druid version.-->
-Apache Druid {{DRUIDVERSION}} contains over $NUMBER_FEATURES new features, bug
fixes, performance enhancements, documentation improvements, and additional
test coverage from $NUMBER_OF_CONTRIBUTORS contributors.
+Apache Druid \{\{DRUIDVERSION}} contains over $NUMBER_FEATURES new features,
bug fixes, performance enhancements, documentation improvements, and additional
test coverage from $NUMBER_OF_CONTRIBUTORS contributors.
Review Comment:
```suggestion
Apache Druid \{{DRUIDVERSION}} contains over $NUMBER_FEATURES new features,
bug fixes, performance enhancements, documentation improvements, and additional
test coverage from $NUMBER_OF_CONTRIBUTORS contributors.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
