aho135 commented on code in PR #17707:
URL: https://github.com/apache/druid/pull/17707#discussion_r1980277247
##########
indexing-service/src/test/java/org/apache/druid/indexing/overlord/supervisor/SupervisorManagerTest.java:
##########
@@ -555,7 +574,7 @@ public void
testGetActiveSupervisorIdForDatasourceWithAppendLock()
EasyMock.replay(activeSpec);
metadataSupervisorManager.insert(EasyMock.anyString(),
EasyMock.anyObject());
- SeekableStreamSupervisorSpec activeSpecWithConcurrentLocks =
EasyMock.mock(SeekableStreamSupervisorSpec.class);
+ SeekableStreamSupervisorSpec activeSpecWithConcurrentLocks =
EasyMock.createNiceMock(SeekableStreamSupervisorSpec.class);
Review Comment:
Now that we are calling shouldUpdateSupervisor within
createOrUpdateAndStartSupervisor, the test fails with Assertions on
jsonMapper.writeValueAsBytes inside shouldUpdateSupervisor.
java.lang.AssertionError:
Unexpected method call SeekableStreamSupervisorSpec.getDataSchema():
I think that when the spec is converted to the byte array, every function in
SeekableStreamSupervisorSpec annotated with @JsonProperty gets called
We could EasyMock.expect each of these calls also. Let me know if you have
any other ideas on this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
