aho135 commented on code in PR #17707:
URL: https://github.com/apache/druid/pull/17707#discussion_r1980293726
##########
indexing-service/src/test/java/org/apache/druid/indexing/overlord/supervisor/SupervisorManagerTest.java:
##########
@@ -555,7 +574,7 @@ public void
testGetActiveSupervisorIdForDatasourceWithAppendLock()
EasyMock.replay(activeSpec);
metadataSupervisorManager.insert(EasyMock.anyString(),
EasyMock.anyObject());
- SeekableStreamSupervisorSpec activeSpecWithConcurrentLocks =
EasyMock.mock(SeekableStreamSupervisorSpec.class);
+ SeekableStreamSupervisorSpec activeSpecWithConcurrentLocks =
EasyMock.createNiceMock(SeekableStreamSupervisorSpec.class);
Review Comment:
Was able to get around this change by just expecting those calls explicitly:
EasyMock.expect(activeSpecWithConcurrentLocks.getSpec()).andReturn(null);
EasyMock.expect(activeSpecWithConcurrentLocks.getDataSchema()).andReturn(null);
EasyMock.expect(activeSpecWithConcurrentLocks.getTuningConfig()).andReturn(null);
EasyMock.expect(activeSpecWithConcurrentLocks.getIoConfig()).andReturn(null);
Let me know which you think is the better approach here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
