kfaraz opened a new pull request, #17816:
URL: https://github.com/apache/druid/pull/17816
### Description
#17802 reverted a retry of failed segment publish actions.
This patch attempts to address the original issue by retrying the segment
publish task actions without
holding any locks so that other transactions are not blocked.
### Changes
- Add class `SegmentPublishAction` that is extended by insert, append and
replace actions
- Add a retry around the actual segment publish method
- Add a field `canRetry` to `SegmentPublishResult`
- Remove class `DataStoreMetadataUpdateResult` and use
`SegmentPublishResult` instead
- Use `Throwables.throwIfUnchecked()` at multiple places to avoid
unnecessary nesting of exceptions
- Cleanup `OverlordResource.doAction()`
- Add null checks to `TaskActionHolder`
<hr>
This PR has:
- [ ] been self-reviewed.
- [ ] using the [concurrency
checklist](https://github.com/apache/druid/blob/master/dev/code-review/concurrency.md)
(Remove this item if the PR doesn't have any relation to concurrency.)
- [ ] added documentation for new or modified features or behaviors.
- [ ] a release note entry in the PR description.
- [ ] added Javadocs for most classes and all non-trivial methods. Linked
related entities via Javadoc links.
- [ ] added or updated version, license, or notice information in
[licenses.yaml](https://github.com/apache/druid/blob/master/dev/license.md)
- [ ] added comments explaining the "why" and the intent of the code
wherever would not be obvious for an unfamiliar reader.
- [ ] added unit tests or modified existing tests to cover new code paths,
ensuring the threshold for [code
coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md)
is met.
- [ ] added integration tests.
- [ ] been tested in a test Druid cluster.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
