kfaraz commented on code in PR #17816:
URL: https://github.com/apache/druid/pull/17816#discussion_r2009685823
##########
server/src/main/java/org/apache/druid/indexing/overlord/SegmentPublishResult.java:
##########
@@ -34,59 +34,59 @@
import java.util.Set;
/**
- * Result of an operation that attempts to publish segments. Indicates the set
of segments actually published
- * and whether or not the transaction was a success.
- *
- * If "success" is false then the segments set will be empty.
- *
- * It's possible for the segments set to be empty even if "success" is true,
since the segments set only
- * includes segments actually published as part of the transaction. The
requested segments could have been
- * published by a different transaction (e.g. in the case of replica sets) and
this one would still succeed.
+ * Result of a segment publish operation.
*/
public class SegmentPublishResult
{
private final Set<DataSegment> segments;
private final boolean success;
- @Nullable
+ private final boolean retryable;
private final String errorMsg;
Review Comment:
Yeah, this particular annotation doesn't do much. Just causes unnecessary
warnings in the IDE.
The constructor arg and the getter are still marked as `@Nullable`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
