maytasm opened a new pull request, #17890: URL: https://github.com/apache/druid/pull/17890
Handle when used_status_last_updated is empty String in HeapMemorySegmentMetadataCache ### Description As the `creates used_status_last_updated VARCHAR(255) NOT NULL` via https://github.com/apache/druid/blob/master/server/src/main/java/org/apache/druid/metadata/SQLMetadataConnector.java#L345 means that the used_status_last_updated can be an empty string, we should handle this case in HeapMemorySegmentMetadataCache. Note that this case will only happen if we downgrade to a version that inserts segments without used_status_last_updated on ingestion or upgrade from such version and the background jobs has not complete backfilling the used_status_last_updated on all the segments. I see that https://github.com/apache/druid/blob/master/server/src/main/java/org/apache/druid/metadata/segment/cache/SegmentRecord.java#L99 means that the cache can work if used_status_last_updated is null and we set null in SegmentRecord. Hence, we should just handle empty string in additional to null so that the HeapMemorySegmentMetadataCache works during these edge cases This PR has: - [ ] been self-reviewed. - [ ] using the [concurrency checklist](https://github.com/apache/druid/blob/master/dev/code-review/concurrency.md) (Remove this item if the PR doesn't have any relation to concurrency.) - [ ] added documentation for new or modified features or behaviors. - [ ] a release note entry in the PR description. - [ ] added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links. - [ ] added or updated version, license, or notice information in [licenses.yaml](https://github.com/apache/druid/blob/master/dev/license.md) - [ ] added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader. - [ ] added unit tests or modified existing tests to cover new code paths, ensuring the threshold for [code coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md) is met. - [ ] added integration tests. - [ ] been tested in a test Druid cluster. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
