kfaraz commented on code in PR #17890: URL: https://github.com/apache/druid/pull/17890#discussion_r2032279739
########## server/src/main/java/org/apache/druid/metadata/segment/cache/SegmentRecord.java: ########## @@ -96,8 +97,8 @@ static SegmentRecord fromResultSet(ResultSet r) } @Nullable - private static DateTime nullSafeDate(String date) + private static DateTime nullAndEmptySafeDate(String date) Review Comment: Since a similar logic is being used elsewhere too, I wonder if we shouldn't just make this a static utility method in `SqlSegmentsMetadataQuery`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
