kfaraz commented on code in PR #18014:
URL: https://github.com/apache/druid/pull/18014#discussion_r2094947052
##########
server/src/main/java/org/apache/druid/segment/realtime/SegmentGenerationMetrics.java:
##########
@@ -297,7 +313,12 @@ public SegmentGenerationMetrics snapshot()
messageGapSnapshot = System.currentTimeMillis() - maxTimestamp;
}
retVal.messageGap.set(messageGapSnapshot);
- retVal.messageGapStats.set(messageGapStats.getAndSet(new
MessageGapStats()));
Review Comment:
In particular, the race condition in comment
https://github.com/apache/druid/pull/17847#discussion_r2094612845 and
https://github.com/apache/druid/pull/17847#discussion_r2094783233, can these
ever happen in the current code or were you referring to future possibilities
in the code?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
