jtuglu-netflix commented on code in PR #18014:
URL: https://github.com/apache/druid/pull/18014#discussion_r2094992642
##########
server/src/main/java/org/apache/druid/segment/realtime/SegmentGenerationMetrics.java:
##########
@@ -297,7 +313,12 @@ public SegmentGenerationMetrics snapshot()
messageGapSnapshot = System.currentTimeMillis() - maxTimestamp;
}
retVal.messageGap.set(messageGapSnapshot);
- retVal.messageGapStats.set(messageGapStats.getAndSet(new
MessageGapStats()));
Review Comment:
Let's get this merged and follow-up with a snapshot fix later. I'm not sure
I see how adding the Snapshot class will change the access-pattern across
threads, considering a read/reset on the gap statistics is still necessary (i.e
you need to pay the price for thread-safety either way). Might just help
readability.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
