kfaraz commented on PR #18082:
URL: https://github.com/apache/druid/pull/18082#issuecomment-2959730090
Note on TODO items:
##### 1
> TBD: Add column dataSource to the druid_supervisors id table for quick
access to a supervisor's datasource.
I don't think this is necessary (at least right now) since we will always
look up supervisors by their ID.
If we want to search supervisors by datasource, the Overlord would already
have them in memory (even if suspended)
and we can just filter them out there.
##### 2
> Figure out DB migration story
By default set the supervisor_id to datasource?
I think we should allow `supervisor_id` in `druid_dataSource` table to be
null for backward compatibility.
##### 3
> Atomic update of multiple specs? So queries can observe a somewhat atomic
schema update
This seems unnecessary since it defeats the purpose of having separate
supervisors.
##### 4
> Fetch supervisors for datasource?
IMO, not needed at the moment. When needed, it will be trivial to update the
existing `getAllSpecs` API
to accept a datasource query parameter. Or even add a new API
`getAllSpecsForDatasource`.
##### 5
> Update sys table?
The `sys.supervisors` table uses the `specGetAll` Overlord API which returns
a set of `SupervisorStatus` objects.
You would need to add a `dataSource` (or `dataSources`) field to
`SupervisorStatus` and have
`SystemSchema.SupervisorsTable` read that field while making a
`SupervisorsEnumerable`.
I think this change would be small, so you can choose to include it in this
PR itself as it would also help you see
the change in action.
##### 6
> UI changes (display datasource column in the supervisors UI)
Given that the supervisors page populates most of the columns using the
`sys.supervisors` table itself,
this change would be trivial but it need not be done as a part of this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
