kfaraz commented on code in PR #18082:
URL: https://github.com/apache/druid/pull/18082#discussion_r2138344021
##########
server/src/main/java/org/apache/druid/metadata/SQLMetadataConnector.java:
##########
@@ -313,17 +313,27 @@ tableName, getPayloadType(), getQuoteString(),
getCollation()
public void createDataSourceTable(final String tableName)
{
+ final List<String> columns = new ArrayList<>();
Review Comment:
Yeah, I agree, it would make metadata queries cleaner.
I suppose the ALTER path could do this in order (hopefully doable in a
single transaction):
- ALTER table ADD new column `supervisor_id`
- UPDATE table SET `supervisor_id` = `dataSource`
- ALTER table DROP old primary key ADD new primary key
Overlord startup would block on this anyway. So new entry would be created
while this is happening.
Let me know if this makes sense.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
