kgyrtkirk commented on code in PR #18127: URL: https://github.com/apache/druid/pull/18127#discussion_r2141911189
########## sql/src/test/java/org/apache/druid/quidem/DruidQuidemTestBase.java: ########## @@ -101,7 +102,7 @@ public abstract class DruidQuidemTestBase private static final String PROPERTY_FILTER = "quidem.filter"; private final String filterStr; - private final List<Pattern> filterPatterns; + private final List<String> filterGlobs; Review Comment: I think this field should have the type `PathMatcher` ; the fact that it might be an `OR` of matchers belongs to the complexity of that `PathMatcher` implementation -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
