gianm commented on code in PR #18127: URL: https://github.com/apache/druid/pull/18127#discussion_r2143034371
########## sql/src/test/java/org/apache/druid/quidem/DruidQuidemTestBase.java: ########## @@ -101,7 +102,7 @@ public abstract class DruidQuidemTestBase private static final String PROPERTY_FILTER = "quidem.filter"; private final String filterStr; - private final List<Pattern> filterPatterns; + private final List<String> filterGlobs; Review Comment: I don't think there is a way to combine two `PathMatcher` with boolean operations- at least I didn't see one. And internally, the `PathMatcher` does not recognize the format `x,y` as being an `OR` of `x` and `y`, which is a feature we currently support for `quidem.filter`. So I think this does have to be a list. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
