cecemei commented on code in PR #18070:
URL: https://github.com/apache/druid/pull/18070#discussion_r2150528365
##########
.github/workflows/unit-and-integration-tests-unified.yml:
##########
@@ -184,33 +187,25 @@ jobs:
pull_number: context.payload.pull_request.number
});
const approved = reviews.data.some(review => review.state ===
'APPROVED');
- core.setOutput("isApproved", approved);
+ core.setOutput("runIts", approved);
- - name: Default to Approved for Branch
+ - name: Default to run ITS for master and release Branch
id: default-check
if: ${{ env.isPR == 'false' }}
- run: echo "::set-output name=isApproved::true"
+ run: echo "::set-output name=runIts::true"
- unit-tests-unapproved:
- name: "unit tests - PR unapproved"
+ unit-tests:
+ name: "unit tests"
uses: ./.github/workflows/ci.yml
- needs: [check-approval]
- if: ${{ needs.check-approval.outputs.approved != 'true' }}
-
- unit-tests-approved:
- name: "unit tests - PR approved"
- uses: ./.github/workflows/ci.yml
- needs: [check-approval]
- if: ${{ needs.check-approval.outputs.approved == 'true' }}
standard-its:
- needs: [build, unit-tests-unapproved, check-approval]
- if: ${{ !cancelled() && (needs.check-approval.outputs.approved == 'true'
|| needs.unit-tests-unapproved.result == 'success') }}
+ needs: [unit-tests, post-build-check]
Review Comment:
ah i see it now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
