kgyrtkirk commented on code in PR #18070:
URL: https://github.com/apache/druid/pull/18070#discussion_r2151674722
##########
.github/workflows/unit-and-integration-tests-unified.yml:
##########
@@ -157,11 +157,14 @@ jobs:
echo ${{ needs.set-env-var.outputs.DRUID_PREVIOUS_IT_IMAGE_NAME }}
docker save "${{
needs.set-env-var.outputs.DRUID_PREVIOUS_IT_IMAGE_NAME }}" | gzip >
druid-container-jdk${{ matrix.jdk }}-version${{
needs.set-env-var.outputs.DRUID_PREVIOUS_VERSION }}.tar.gz
- # check if it is a PR and if it is approved. For approved PRs, we do not
want to run tests sequentially
- check-approval:
+ # check if we want to run ITS after build immediately, if one of the
following conditions is met:
+ # - It's a PR and approved. For approved PRs, we do not want to run tests
sequentially.
+ # - It's a push to master or release branch, in which case we run ITS
without waiting for unit tests.
Review Comment:
I think this feature doesn't worth the effort/complexity
* originally unit tests were running for 1h after a 10m build phase;
* it not should run around 20m
so it has much less value - removing the `check-approval` part and the
duplicated test run will make it more straight
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
