gianm commented on code in PR #18338:
URL: https://github.com/apache/druid/pull/18338#discussion_r2239383463
##########
processing/src/main/java/org/apache/druid/java/util/metrics/cgroups/Cpu.java:
##########
@@ -77,7 +77,7 @@ public CpuMetrics snapshot()
}
}
catch (IOException | RuntimeException ex) {
- LOG.error(ex, "Unable to fetch cpu snapshot");
+ LOG.noStackTrace().error(ex, "Unable to fetch cpu snapshot");
Review Comment:
This should be `warn`. Error is reserved for serious errors, but this isn't
one, it just means that some metrics won't be reported. Btw, the error message
should have more detail about the impact. It should mention that this means
that `cgroup` metrics will not be emitted. Such as:
```
Unable to fetch CPU snapshot. Cgroup metrics will not be emitted.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
