uds5501 commented on code in PR #18338:
URL: https://github.com/apache/druid/pull/18338#discussion_r2241947027
##########
processing/src/main/java/org/apache/druid/java/util/metrics/cgroups/Cpu.java:
##########
@@ -77,7 +77,7 @@ public CpuMetrics snapshot()
}
}
catch (IOException | RuntimeException ex) {
- LOG.error(ex, "Unable to fetch cpu snapshot");
+ LOG.noStackTrace().error(ex, "Unable to fetch cpu snapshot");
Review Comment:
I don't think that would work, within `CgroupV2CpuMonitor` is supposed to
use `ProcCgroupV2Discoverer` , that itself does not seem to implement the
`discover(String cgroup)` completely . The `cgroup` is not being used in the
[function](https://github.com/apache/druid/blob/d9f0af84af0d5ac85abd767777aa4c68c8640b23/processing/src/main/java/org/apache/druid/java/util/metrics/cgroups/ProcCgroupV2Discoverer.java#L45)
anywhere so I am not confident that it's complete in itself.
Additionally `CgroupV2CpuMonitor` is marked `experimental` so I don't think
we should be switching it internally.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
