kfaraz commented on code in PR #18302:
URL: https://github.com/apache/druid/pull/18302#discussion_r2239393498
##########
services/src/test/java/org/apache/druid/testing/embedded/EmbeddedDruidCluster.java:
##########
@@ -231,13 +242,50 @@ public TestFolder getTestFolder()
}
/**
- * The embedded Zookeeper server used by this cluster, if any.
- *
- * @throws NullPointerException if this cluster has no embedded zookeeper.
+ * Hostname to be used for embedded services (both Druid or external).
+ * Using this hostname ensures that the underlying service is reachable by
both
+ * EmbeddedDruidServers and DruidContainers.
+ */
+ public String getEmbeddedServiceHostname()
+ {
+ return hasDruidContainers ? getDefaultHost() : "localhost";
+ }
+
+ /**
+ * Hostname for the host machine running the containers. Using this hostname
+ * instead of "localhost" allows all the Druid containers to talk to each
+ * other and also other EmbeddedDruidServers.
*/
- public EmbeddedZookeeper getZookeeper()
+ public static String getDefaultHost()
{
- return Objects.requireNonNull(zookeeper, "No embedded zookeeper configured
for this cluster");
+ try {
+ return InetAddress.getLocalHost().getHostAddress();
+ }
+ catch (UnknownHostException e) {
+ throw new ISE(e, "Unable to determine host name");
+ }
+ }
+
+ /**
+ * Replaces {@code localhost} or {@code 127.0.0.1} in the given connectUri
+ * with {@link #getEmbeddedServiceHostname()}. Using the embedded URI ensures
+ * that the underlying service is reachable by both EmbeddedDruidServers and
+ * DruidContainers.
+ */
+ public String getEmbeddedConnectUri(String connectUri)
+ {
+ if (!hasDruidContainers) {
+ return connectUri;
+ } else if (connectUri.contains("localhost")) {
+ return StringUtils.replace(connectUri, "localhost",
getEmbeddedServiceHostname());
Review Comment:
fair enough 😂 , I have updated it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
