kfaraz commented on PR #18302: URL: https://github.com/apache/druid/pull/18302#issuecomment-3140124400
@gianm , thanks for the feedback. I have made the following changes: - Added a script `run_docker-tests`. - This script is used by GHA and can also be used to run all docker tests - The script expects an environment variable to be set. Otherwise the tests are not run. - While voting on release candidates, committers can just invoke this script with the correct image name. If not available, the image would be downloaded by Testcontainers itself. - Docker tests are now disabled by default and will be triggered only in `mvn verify` given that the required system property `-Ddruid.testing.docker.image` is set. @kgyrtkirk , I think you had also suggested using `verify` phase and adding a dedicated script. Please let me know if this makes sense. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
