clintropolis commented on code in PR #18334:
URL: https://github.com/apache/druid/pull/18334#discussion_r2246462428
##########
processing/src/main/java/org/apache/druid/segment/virtual/ExpressionVirtualColumn.java:
##########
@@ -125,8 +124,11 @@ private ExpressionVirtualColumn(
)
{
this.name = Preconditions.checkNotNull(name, "name");
- this.expression = new Expression(Preconditions.checkNotNull(expression,
"expression"), outputType);
- this.parsedExpression = parsedExpression;
+ this.expression = new Expression(
Review Comment:
I'm not going to remove `Parser.lazyParse`, this is behind a supplier so we
don't spend time parsing expressions unless we actually need to do something
with the `Expr` since parsing the expression can add up quite a bit in terms of
cpu cost
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
