clintropolis commented on code in PR #18334:
URL: https://github.com/apache/druid/pull/18334#discussion_r2246529714
##########
processing/src/main/java/org/apache/druid/segment/virtual/ExpressionVirtualColumn.java:
##########
@@ -449,20 +456,21 @@ public boolean equals(Object o)
return false;
}
Expression that = (Expression) o;
- return Objects.equals(expressionString, that.expressionString) &&
Objects.equals(outputType, that.outputType);
+ return Objects.equals(parsed.get().stringify(),
that.parsed.get().stringify())
Review Comment:
i suppose more technically we need an actual equivalence method for `Expr`
to power all of this stuff, then it could handle more general equivalence like
`a + b` and `b + a` being interchangeable, but that's too much for this PR i
think
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
