uds5501 commented on code in PR #18341:
URL: https://github.com/apache/druid/pull/18341#discussion_r2259195066


##########
processing/src/main/java/org/apache/druid/tasklogs/TaskLogPusher.java:
##########
@@ -39,4 +39,9 @@ default void pushTaskReports(String taskid, File reportFile) 
throws IOException
   default void pushTaskStatus(String taskid, File reportFile) throws 
IOException
   {
   }
+
+  default boolean logPushEnabled()

Review Comment:
   The `TaskLogPusher`  has varied responsibilities internally (reports, logs, 
statuses etc). This boolean helps in the scenario of K8S runners where it 
creates a temp file before pushing the logs to deep storage. This method helps 
skip the entire step



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to