kfaraz commented on code in PR #18341:
URL: https://github.com/apache/druid/pull/18341#discussion_r2245216950
##########
indexing-service/src/main/java/org/apache/druid/guice/IndexingServiceTaskLogsModule.java:
##########
@@ -39,13 +42,22 @@ public class IndexingServiceTaskLogsModule implements Module
public void configure(Binder binder)
{
PolyBind.createChoice(binder, "druid.indexer.logs.type",
Key.get(TaskLogs.class), Key.get(FileTaskLogs.class));
+ PolyBind.createChoice(binder, "druid.indexer.logs.delegate.type",
Key.get(TaskLogs.class, Names.named("delegate")), Key.get(FileTaskLogs.class));
Review Comment:
@uds5501 , I don't think we need two levels of a switching implementation.
That would really complicate the configs.
You can provide some decent defaults
When `druid.indexer.logs.type=switching`
|Property|Default|
|---------|-------|
|`druid.indexer.logs.switching.defaultType`|`file`|
|`druid.indexer.logs.switching.logPushType`|use `defaultType`|
|`druid.indexer.logs.switching.logStreamType`|use `defaultType`|
|`druid.indexer.logs.switching.reportsType`|use `defaultType`|
I don't think report and payload will ever need to be different.
If needed, we can add it in the future.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
