capistrant commented on code in PR #18383: URL: https://github.com/apache/druid/pull/18383#discussion_r2265497027
########## embedded-tests/src/test/java/org/apache/druid/testing/embedded/indexing/KafkaDataFormatsTest.java: ########## @@ -0,0 +1,716 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.druid.testing.embedded.indexing; + +import com.fasterxml.jackson.core.JsonProcessingException; +import com.fasterxml.jackson.core.type.TypeReference; +import com.fasterxml.jackson.databind.ObjectMapper; +import org.apache.druid.data.input.InputFormat; +import org.apache.druid.data.input.avro.AvroExtensionsModule; +import org.apache.druid.data.input.avro.AvroStreamInputFormat; +import org.apache.druid.data.input.avro.SchemaRegistryBasedAvroBytesDecoder; +import org.apache.druid.data.input.impl.CsvInputFormat; +import org.apache.druid.data.input.impl.DelimitedInputFormat; +import org.apache.druid.data.input.impl.DimensionsSpec; +import org.apache.druid.data.input.impl.JsonInputFormat; +import org.apache.druid.data.input.impl.TimestampSpec; +import org.apache.druid.data.input.protobuf.FileBasedProtobufBytesDecoder; +import org.apache.druid.data.input.protobuf.ProtobufExtensionsModule; +import org.apache.druid.data.input.protobuf.ProtobufInputFormat; +import org.apache.druid.data.input.protobuf.SchemaRegistryBasedProtobufBytesDecoder; +import org.apache.druid.indexing.kafka.KafkaIndexTaskModule; +import org.apache.druid.indexing.kafka.simulate.KafkaResource; +import org.apache.druid.indexing.kafka.supervisor.KafkaSupervisorIOConfig; +import org.apache.druid.indexing.kafka.supervisor.KafkaSupervisorSpec; +import org.apache.druid.indexing.kafka.supervisor.KafkaSupervisorTuningConfig; +import org.apache.druid.java.util.common.StringUtils; +import org.apache.druid.query.DruidMetrics; +import org.apache.druid.segment.TestHelper; +import org.apache.druid.segment.indexing.DataSchema; +import org.apache.druid.testing.embedded.EmbeddedBroker; +import org.apache.druid.testing.embedded.EmbeddedCoordinator; +import org.apache.druid.testing.embedded.EmbeddedDruidCluster; +import org.apache.druid.testing.embedded.EmbeddedHistorical; +import org.apache.druid.testing.embedded.EmbeddedIndexer; +import org.apache.druid.testing.embedded.EmbeddedOverlord; +import org.apache.druid.testing.embedded.junit5.EmbeddedClusterTestBase; +import org.apache.druid.testing.tools.AvroSchemaRegistryEventSerializer; +import org.apache.druid.testing.tools.EventSerializer; +import org.apache.druid.testing.tools.ProtobufSchemaRegistryEventSerializer; +import org.apache.druid.testing.tools.StreamGenerator; +import org.apache.druid.testing.tools.WikipediaStreamEventStreamGenerator; +import org.apache.kafka.clients.producer.ProducerRecord; +import org.joda.time.Period; +import org.junit.jupiter.api.Assertions; +import org.junit.jupiter.api.BeforeAll; +import org.junit.jupiter.api.Test; +import org.junit.jupiter.api.Timeout; + +import java.io.IOException; +import java.util.ArrayList; +import java.util.List; +import java.util.Map; +import java.util.concurrent.TimeUnit; + +/** + * Embedded test of kafka indexing for different data formats. + * Formats Included: + * <ul> + * Avro (with and without schema registry) + * CSV + * JSON + * Protobuf (with and without schema registry) + * </ul> + * + * This tests both InputFormat and Parser. Parser is deprecated for Kafka Ingestion, and those tests will be removed in the future. + */ +public class KafkaDataFormatsTest extends EmbeddedClusterTestBase +{ + private static final long CYCLE_PADDING_MS = 100; + private static final int EVENTS_PER_SECOND = 6; + + + private static ObjectMapper jsonMapper; + private final EmbeddedBroker broker = new EmbeddedBroker(); + private final EmbeddedIndexer indexer = new EmbeddedIndexer(); + private final EmbeddedOverlord overlord = new EmbeddedOverlord(); + private final EmbeddedHistorical historical = new EmbeddedHistorical(); + private final EmbeddedCoordinator coordinator = new EmbeddedCoordinator(); + private KafkaResource kafkaServer; + private SchemaRegistryResource schemaRegistry; + + @BeforeAll + public static void beforeAll() + { + jsonMapper = TestHelper.JSON_MAPPER; + } + + @Override + public EmbeddedDruidCluster createCluster() + { + final EmbeddedDruidCluster cluster = EmbeddedDruidCluster.withEmbeddedDerbyAndZookeeper().useContainerFriendlyHostname(); + + kafkaServer = new KafkaResource() + { + @Override + public void start() + { + super.start(); + } + + @Override + public void stop() + { + super.stop(); + } + }; + + schemaRegistry = new SchemaRegistryResource() + { + @Override + public void start() + { + this.kafkaContainer = kafkaServer.getContainer(); + super.start(); + } + + @Override + public void stop() + { + super.stop(); + } + }; + + indexer.addProperty("druid.segment.handoff.pollDuration", "PT0.1s") + .addProperty("druid.worker.capacity", "10"); + overlord.addProperty("druid.indexer.task.default.context", "{\"useConcurrentLocks\": true}") + .addProperty("druid.manager.segments.useIncrementalCache", "ifSynced") + .addProperty("druid.manager.segments.pollDuration", "PT0.1s") + .addProperty("druid.manager.segments.killUnused.enabled", "true") + .addProperty("druid.manager.segments.killUnused.bufferPeriod", "PT0.1s") + .addProperty("druid.manager.segments.killUnused.dutyPeriod", "PT1s"); + coordinator.addProperty("druid.manager.segments.useIncrementalCache", "ifSynced"); + cluster.addExtension(KafkaIndexTaskModule.class) + .addExtension(ProtobufExtensionsModule.class) + .addExtension(AvroExtensionsModule.class) + .useLatchableEmitter() + .addCommonProperty("druid.monitoring.emissionPeriod", "PT0.1s") + .addCommonProperty( + "druid.monitoring.monitors", + "[\"org.apache.druid.java.util.metrics.JvmMonitor\"," + + "\"org.apache.druid.server.metrics.TaskCountStatsMonitor\"]" + ) Review Comment: The current implementation does wait on a task count metric, but I removed the jvm monitor. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
