capistrant commented on PR #18383: URL: https://github.com/apache/druid/pull/18383#issuecomment-3173124454
@kfaraz The detailed review is greatly appreciated! I began making changes in response. but I still have not looked into why all the other ITs are failing now so I assume there are more changes to be done yet. Left a clarifying question in your comment about using a builder instead of json strings for creating bits of the supervisor specs. Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
