capistrant commented on code in PR #18444:
URL: https://github.com/apache/druid/pull/18444#discussion_r2307168508
##########
extensions-core/kubernetes-overlord-extensions/src/main/java/org/apache/druid/k8s/overlord/KubernetesPeonLifecycle.java:
##########
@@ -349,6 +356,24 @@ protected void startWatchingLogs()
}
protected void saveLogs()
+ {
+ ExecutorService executor = Executors.newSingleThreadExecutor();
Review Comment:
> Does it make sense to expose the timeouts here
>
>
https://github.com/fabric8io/kubernetes-client?tab=readme-ov-file#configuring-the-client
>
> rather than doing a timeout via an exec service ?
>
>
>
>
https://github.com/fabric8io/kubernetes-client/issues/7163
From talking with @kgyrtkirk i was under the impression that the reason this
log read can hang is because of the above bug. I don't think any existing
timeouts can fix that. But we could also expose all the timeouts that fabric8
supplies as part of this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
