capistrant commented on code in PR #18444:
URL: https://github.com/apache/druid/pull/18444#discussion_r2319486330
##########
extensions-core/kubernetes-overlord-extensions/src/main/java/org/apache/druid/k8s/overlord/KubernetesPeonLifecycle.java:
##########
@@ -349,6 +356,24 @@ protected void startWatchingLogs()
}
protected void saveLogs()
+ {
+ ExecutorService executor = Executors.newSingleThreadExecutor();
Review Comment:
@kgyrtkirk you raise good points. The only reason I'm proposing this is
because of the fabric8 bug not being available in any release. I'd like to
remove it ASAP once fabric8 does a release or patch release with this fix.
maybe we need to take a step back and consider making the client pluggable
allowing for operators to migrate between clients. vertx has solved a lot of
problems for some use cases but caused other problems.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
