kfaraz commented on code in PR #18477:
URL: https://github.com/apache/druid/pull/18477#discussion_r2321015803


##########
processing/src/main/java/org/apache/druid/java/util/common/Intervals.java:
##########
@@ -53,6 +57,46 @@ public static Interval of(String format, Object... 
formatArgs)
     return of(StringUtils.format(format, formatArgs));
   }
 
+  /**
+   * @return Null if cannot parse with optimized strategy, else return the 
Interval.

Review Comment:
   > I have listed all cases i can think of under the test file.
   
   Please also list out these cases briefly in the javadoc of the new 
`Intervals.fromString()` method



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org
For additional commands, e-mail: commits-h...@druid.apache.org

Reply via email to