kfaraz commented on PR #18477: URL: https://github.com/apache/druid/pull/18477#issuecomment-3257554095
> since it deals with data of this shape: "datasource_2015-01-02T00:00:00.000Z_2015-01-03T00:00:00.000Z_ver_0_1", but our Interval representation is "2015-01-02T00:00:00.000Z/2015-01-03T00:00:00.000Z". Thanks for checking, @GWphua ! We would need to add some new constructor to `SegmentId` to make it work but we might as well just use the new method you have already added in this PR. > I can change DataSegment's interval input to String type, and use Intervals.fromString() on it to give the performance boost, since that's the goal of this PR -- to optimize the deserialization time for DataSegment. I have previously used Intervals.fromString() to be the default deserializer in JodaStuff. Now will revert that change, and use deserialization for only DataSegments. Yeah, this makes sense. Let's proceed with this. Please make this JsonCreator constructor private and add a separate constructor so that all the call sites need not change. In the javadoc of `Intervals.fromString()`, please indicate that this method is to be used for segment intervals only (at least for the time being). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
