GWphua commented on PR #18477: URL: https://github.com/apache/druid/pull/18477#issuecomment-3257506148
@kfaraz I'm having trouble trying to use segmentId's `tryParse()`, since it deals with data of this shape: `"datasource_2015-01-02T00:00:00.000Z_2015-01-03T00:00:00.000Z_ver_0_1"`, but our Interval representation is `"2015-01-02T00:00:00.000Z/2015-01-03T00:00:00.000Z"`. This means we will require some manipulation of the String that's going into DataSegment. lmk if im missing anything! I can change DataSegment's `interval` input to `String` type, and use `Intervals.fromString()` on it to give the performance boost, since that's the goal of this PR -- to optimize the deserialization time for `DataSegment`. If we figure out that most of Druid handles interval string representation of the compatible type format, we can consider using the optimized deserialization strategy instead. I have previously used `Intervals.fromString()` to be the default deserializer in `JodaStuff`. Now will revert that change, and use deserialization for only DataSegments. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
