kfaraz commented on code in PR #18542:
URL: https://github.com/apache/druid/pull/18542#discussion_r2361731334
##########
sql/src/test/java/org/apache/druid/sql/calcite/schema/SystemSchemaTest.java:
##########
@@ -381,6 +381,8 @@ public void setUp(@TempDir File tmpDir) throws Exception
private final DateTime startTime = DateTimes.nowUtc();
+ private final String version = new DruidNode("s1", "localhost", false, 8081,
null, true, false).getVersion();
Review Comment:
I don't think `DruidNode` exposes any `getVersion` method.
Also, if we just need the version, why instantiate a `DruidNode`?
##########
docs/querying/sql-metadata-tables.md:
##########
@@ -236,6 +236,7 @@ Servers table lists all discovered servers in the cluster.
|max_size|BIGINT|Max size in bytes this server recommends to assign to
segments see
[druid.server.maxSize](../configuration/index.md#historical-general-configuration).
Only valid for HISTORICAL type, for other types it's 0|
|is_leader|BIGINT|1 if the server is currently the 'leader' (for services
which have the concept of leadership), otherwise 0 if the server is not the
leader, or null if the server type does not have the concept of leadership|
|start_time|STRING|Timestamp in ISO8601 format when the server was announced
in the cluster|
+|version|VARCHAR|Version of the server|
Review Comment:
```suggestion
|version|VARCHAR|Druid version running on the server|
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
