kfaraz commented on code in PR #18542:
URL: https://github.com/apache/druid/pull/18542#discussion_r2367958449
##########
sql/src/test/java/org/apache/druid/sql/calcite/schema/SystemSchemaTest.java:
##########
@@ -381,6 +381,8 @@ public void setUp(@TempDir File tmpDir) throws Exception
private final DateTime startTime = DateTimes.nowUtc();
+ private final String version = new DruidNode("s1", "localhost", false, 8081,
null, true, false).getVersion();
Review Comment:
Thanks for the clarification! I must have been looking at older code.
Actually, the better thing to do would be to make the `unknown` a constant
in `DruidNode` and use it here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
