uds5501 commented on code in PR #18466:
URL: https://github.com/apache/druid/pull/18466#discussion_r2371102317
##########
indexing-service/src/main/java/org/apache/druid/indexing/seekablestream/SeekableStreamIndexTaskRunner.java:
##########
@@ -1275,7 +1298,7 @@ private void addSequence(final
SequenceMetadata<PartitionIdType, SequenceOffsetT
if (!sequences.isEmpty()) {
final SequenceOffsetType priorOffset =
getLastSequenceMetadata().endOffsets.get(partition);
- if (!startOffset.equals(priorOffset)) {
+ if (priorOffset != null && !startOffset.equals(priorOffset)) {
Review Comment:
No, the `startOffset` is being supplied by updateConfig / setEndOffsets
path, the supervisor ensures that start offset is not null there.
However in partition reassignment, the supervisor may give offsets for
certain partitions that may not have been assigned to this runner before, hence
the `priorOffset` might be null.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
