uds5501 commented on code in PR #18466:
URL: https://github.com/apache/druid/pull/18466#discussion_r2371930340


##########
indexing-service/src/main/java/org/apache/druid/indexing/seekablestream/SeekableStreamIndexTaskRunner.java:
##########
@@ -1738,7 +1899,10 @@ public Response setEndOffsets(
                      .build();
     } else {
       try {
-        pauseLock.lockInterruptibly();
+        // Don't acquire a lock if the task is already paused for checkpoint 
completion, avoiding deadlock
+        if (!waitForConfigUpdate.get()) {
+          pauseLock.lockInterruptibly();
+        }

Review Comment:
   Changed the `!waitForConfigUpdate.get()` to `shouldPause`, rest has been 
discussed offline



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to