kfaraz commented on code in PR #18510:
URL: https://github.com/apache/druid/pull/18510#discussion_r2378631926
##########
indexing-service/src/main/java/org/apache/druid/indexing/overlord/hrtr/HttpRemoteTaskRunner.java:
##########
@@ -1543,6 +1550,9 @@ public void taskAddedOrUpdated(final TaskAnnouncement
announcement, final Worker
HttpRemoteTaskRunnerWorkItem.State.RUNNING
);
tasks.put(taskId, taskItem);
+ final ServiceMetricEvent.Builder metricBuilder = new
ServiceMetricEvent.Builder();
+ metricBuilder.setDimension(DruidMetrics.TASK_ID, taskId);
+ emitter.emit(metricBuilder.setMetric(TASK_UNKNOWN_COUNT, (long)
1));
Review Comment:
> as
[HttpRemoteTaskRunner](https://github.com/apache/druid/blob/9481a535be627d2e9cb1974e68eb12935e70e5b3/indexing-service/src/main/java/org/apache/druid/indexing/overlord/hrtr/HttpRemoteTaskRunner.java#L569)
blocks untile workers sync state.
which blocks the DruidOverlord#becomeLeader thru Lifecycle#start
I see. Thanks for the clarification!
So, IIUC, this metric will always be emitted for all running tasks whenever
the Overlord is restarted?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
