kgyrtkirk commented on code in PR #18510:
URL: https://github.com/apache/druid/pull/18510#discussion_r2377914230
##########
indexing-service/src/test/java/org/apache/druid/indexing/common/task/batch/parallel/TaskMonitorTest.java:
##########
@@ -296,10 +305,23 @@ public ListenableFuture<Void> runTask(String taskId,
Object taskObject)
if (task.throwUnknownTypeIdError) {
throw new RuntimeException(new ISE("Could not resolve type id
'test_task_id'"));
}
- taskRunner.submit(() -> tasks.put(task.getId(),
task.run(null).getStatusCode()));
+ TaskToolbox taskToolbox = makeToolbox();
+ taskRunner.submit(() -> tasks.put(task.getId(),
task.run(taskToolbox).getStatusCode()));
Review Comment:
because test did not set up things correctly...emitting a metric in the task
have hit the wall that its simply not set...
I also had to undo the `stopGracefully` enhancements from the `NoopTask` as
it seemed like it was destabilizing some other tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
