jtuglu1 commented on code in PR #18639:
URL: https://github.com/apache/druid/pull/18639#discussion_r2434207212
##########
services/src/main/java/org/apache/druid/server/AsyncQueryForwardingServlet.java:
##########
@@ -760,13 +760,17 @@ public void onComplete(Result result)
return;
}
- boolean success = result.isSucceeded();
Review Comment:
> Why was this logic for success changed from result.isSucceeded() to
result.getResponse().getStatus()? I think this would change the semantics of
what counts as a successful query to strictly a query that's returning with a
200 OK code.
See PR description. result.isSucceeded() is the buggy logic. This assumption
is already being made a few lines down
[here](https://github.com/apache/druid/blob/master/services/src/main/java/org/apache/druid/server/AsyncQueryForwardingServlet.java#L789-L790).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
