jtuglu1 commented on code in PR #18639:
URL: https://github.com/apache/druid/pull/18639#discussion_r2434209714
##########
services/src/main/java/org/apache/druid/server/AsyncQueryForwardingServlet.java:
##########
@@ -760,13 +760,17 @@ public void onComplete(Result result)
return;
}
- boolean success = result.isSucceeded();
+ final int statusCode = result.getResponse().getStatus();
Review Comment:
> On the router, I suppose this is fine especially as
result.getResponse().getStatus() would effectively translate to the same error
code as the underlying exception, if it’s of type DruidException/QueryException?
Yes. Router is stateless and doesn't handle any business logic (aside from
potential auth errors, etc.). It shouldn't make an attempt to parse any of the
exceptions in this case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
