clintropolis commented on code in PR #18750:
URL: https://github.com/apache/druid/pull/18750#discussion_r2563010364
##########
extensions-core/kafka-indexing-service/src/main/java/org/apache/druid/indexing/kafka/supervisor/KafkaSupervisor.java:
##########
@@ -294,13 +295,16 @@ protected Map<KafkaTopicPartition, Long>
getPartitionTimeLag()
// suppress use of CollectionUtils.mapValues() since the valueMapper
function is dependent on map key here
@SuppressWarnings("SSBasedInspection")
// Used while calculating cummulative lag for entire stream
- private Map<KafkaTopicPartition, Long>
getRecordLagPerPartitionInLatestSequences(Map<KafkaTopicPartition, Long>
currentOffsets)
+ private Map<KafkaTopicPartition, Long>
getRecordLagPerPartitionInLatestSequences()
{
- if (latestSequenceFromStream == null) {
+ Map<KafkaTopicPartition, Long> currentOffsets =
offsetSnapshotRef.get().getCurrentOffsets();
+ Map<KafkaTopicPartition, Long> endOffsets =
offsetSnapshotRef.get().getEndOffsets();
Review Comment:
seems like we should break out `offsetSnapshotRef.get()` so that these two
offsets maps are from the same `OffsetSnapshot`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
