github-advanced-security[bot] commented on code in PR #18844:
URL: https://github.com/apache/druid/pull/18844#discussion_r2692438453
##########
server/src/test/java/org/apache/druid/server/compaction/CompactionStatusTest.java:
##########
@@ -537,9 +576,257 @@
final DataSegment segment =
DataSegment.builder(WIKI_SEGMENT).lastCompactionState(lastCompactionState).build();
final CompactionStatus status = CompactionStatus.compute(
CompactionCandidate.from(List.of(segment), null),
- compactionConfig
+ compactionConfig,
+ fingerprintMapper
+ );
+ Assert.assertFalse(status.isComplete());
+ }
+
+ @Test
+ public void
test_evaluate_needsCompactionWhenAllSegmentsHaveUnexpectedIndexingStateFingerprint()
+ {
+ List<DataSegment> segments = List.of(
+
DataSegment.builder(WIKI_SEGMENT).indexingStateFingerprint("wrongFingerprint").build(),
+
DataSegment.builder(WIKI_SEGMENT_2).indexingStateFingerprint("wrongFingerprint").build()
+ );
+
+ final DataSourceCompactionConfig oldCompactionConfig =
InlineSchemaDataSourceCompactionConfig
+ .builder()
+ .forDataSource(TestDataSource.WIKI)
+ .withGranularitySpec(new
UserCompactionTaskGranularityConfig(Granularities.HOUR, null, null))
+ .build();
+ CompactionState wrongState = oldCompactionConfig.toCompactionState();
+
+ final DataSourceCompactionConfig compactionConfig =
InlineSchemaDataSourceCompactionConfig
+ .builder()
+ .forDataSource(TestDataSource.WIKI)
+ .withGranularitySpec(new
UserCompactionTaskGranularityConfig(Granularities.DAY, null, null))
+ .build();
+
+ CompactionState expectedState = compactionConfig.toCompactionState();
Review Comment:
## Unread local variable
Variable 'CompactionState expectedState' is never read.
[Show more
details](https://github.com/apache/druid/security/code-scanning/10764)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
