kfaraz commented on code in PR #18844:
URL: https://github.com/apache/druid/pull/18844#discussion_r2697026181
##########
server/src/main/java/org/apache/druid/metadata/SQLMetadataConnector.java:
##########
@@ -355,6 +366,8 @@ public void createSegmentTable(final String tableName)
columns.add("used BOOLEAN NOT NULL");
columns.add("payload %2$s NOT NULL");
columns.add("used_status_last_updated VARCHAR(255) NOT NULL");
+ columns.add("indexing_state_fingerprint VARCHAR(255)");
+ columns.add("upgraded_from_segment_id VARCHAR(255)");
if (centralizedDatasourceSchemaConfig.isEnabled()) {
Review Comment:
Yeah, I agree. It should be okay to always have these columns in the schema
since they are anyway nullable.
We can do it in a separate PR, though, and ensure that we are not breaking
any weird assumptions related to this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
