abhishekrb19 commented on code in PR #19040:
URL: https://github.com/apache/druid/pull/19040#discussion_r2862091030
##########
indexing-service/src/main/java/org/apache/druid/indexing/seekablestream/supervisor/SeekableStreamSupervisorIOConfig.java:
##########
@@ -119,6 +121,21 @@ public SeekableStreamSupervisorIOConfig(
}
this.idleConfig = idleConfig;
+ this.serverPriorityToReplicas = serverPriorityToReplicas;
+ if (this.serverPriorityToReplicas != null) {
+ final int replicaCount =
this.serverPriorityToReplicas.values().stream().mapToInt(Integer::intValue).sum();
+ if (replicas != null && replicas != replicaCount) {
+ throw InvalidInput.exception(
Review Comment:
This would be triggered only if someone unintentionally sets conflicting
values that cause ambiguity. I wanted to keep the behavior straightforward for
end users rather than document any precedence rules in such cases. I've updated
the error message accordingly, please let me know if that makes sense.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
