aho135 commented on code in PR #19040:
URL: https://github.com/apache/druid/pull/19040#discussion_r2874791674


##########
docs/ingestion/supervisor.md:
##########
@@ -65,6 +65,7 @@ For configuration properties specific to Kafka and Kinesis, 
see [Kafka I/O confi
 |`lateMessageRejectionPeriod`|ISO 8601 period|Configures tasks to reject 
messages with timestamps earlier than this period before the task was created. 
For example, if this property is set to `PT1H` and the supervisor creates a 
task at `2016-01-01T12:00Z`, Druid drops messages with timestamps earlier than 
`2016-01-01T11:00Z`. This may help prevent concurrency issues if your data 
stream has late messages and you have multiple pipelines that need to operate 
on the same segments, such as a streaming and a nightly batch ingestion 
pipeline. You can specify only one of the late message rejection 
properties.|No||
 |`earlyMessageRejectionPeriod`|ISO 8601 period|Configures tasks to reject 
messages with timestamps later than this period after the task reached its task 
duration. For example, if this property is set to `PT1H`, the task duration is 
set to `PT1H` and the supervisor creates a task at `2016-01-01T12:00Z`, Druid 
drops messages with timestamps later than `2016-01-01T14:00Z`. Tasks sometimes 
run past their task duration, such as in cases of supervisor failover.|No||
 |`stopTaskCount`|Integer|Limits the number of ingestion tasks Druid can cycle 
at any given time. If not set, Druid can cycle all tasks at the same time. If 
set to a value less than `taskCount`, your cluster needs fewer available slots 
to run the supervisor. You can save costs by scaling down your ingestion tier, 
but this can lead to slower cycle times and lag. See 
[`stopTaskCount`](#stoptaskcount) for more information.|No|`taskCount` value|
+|`serverPriorityToReplicas`|Object (`Map<Integer, Integer>`)|Map of server 
priorities to the number of replicas per priority. When set, each task replica 
is assigned a server priority that corresponds to `druid.server.priority` on 
the Peon process to enable query isolation for mixed workloads using [query 
routing strategies](../configuration/index.md#query-routing). If not 
configured, the `replicas` setting applies and all task replicas are assigned a 
default priority of 0.<br/><br/>For example, setting `serverPriorityToReplicas` 
to `{"1": 2, "0": 1}` creates 2 task replicas with `druid.server.priority=1` 
and 1 task replica with `druid.server.priority=0` per task group. This 
configuration scales proportionally with `taskCount`. For example, if 
`taskCount` is set to 5, this results in 15 total tasks - 10 tasks with 
priority 1 and 5 tasks with priority 0.|No|null|

Review Comment:
   ```suggestion
   |`serverPriorityToReplicas`|Object (`Map<Integer, Integer>`)|Map of server 
priorities to the number of replicas per priority. When set, each task replica 
is assigned a server priority that corresponds to `druid.server.priority` on 
the Peon process to enable query isolation for mixed workloads using [query 
routing strategies](../configuration/index.md#query-routing). If not 
configured, the `replicas` setting applies and all task replicas are assigned a 
default priority of 0.<br/><br/>For example, setting `replicas` to 3 and 
`serverPriorityToReplicas` to `{"1": 2, "0": 1}` creates 2 task replicas with 
`druid.server.priority=1` and 1 task replica with `druid.server.priority=0` per 
task group. This configuration scales proportionally with `taskCount`. For 
example, if `taskCount` is set to 5, this results in 15 total tasks - 10 tasks 
with priority 1 and 5 tasks with priority 0.|No|null|
   ```
   
   This helps make it more clear that the sum of Replicas has to equal 
configured `replicas`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to